https://bugzilla.redhat.com/show_bug.cgi?id=1751590 Adam Williamson <awilliam@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |awilliam@xxxxxxxxxx --- Comment #1 from Adam Williamson <awilliam@xxxxxxxxxx> --- We have %py3_build and %py3_install macros - maybe use those? Shouldn't LICENSE be %license, not %doc? What's the deal with all the commented-out Requires: lines? Shouldn't those be reviewed and if appropriate updated, or removed? Per the guidelines - https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ - the package that contains the modules (in this case, there is only one package) *must* Provides: python3-(modulename) for each module - https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_provides . It doesn't matter that this is an application, as long as it's shipping modules installed to the system-wide path it needs to follow the rules for modules. FWIW I would usually separate the modules into one or more subpackages and have the 'binary' in its own package that depended on the module subpackages, but that's not required. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
