https://bugzilla.redhat.com/show_bug.cgi?id=1750823 --- Comment #4 from Pino Toscano <ptoscano@xxxxxxxxxx> --- (In reply to Richard W.M. Jones from comment #3) > Issues: > ======= > - If (and only if) the source package includes the text of the license(s) > in its own file, then that file, containing the text of the license(s) > for the package is included in %license. > Note: License file COPYING is not marked as %license > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/LicensingGuidelines/#_license_text > > It seems as if the %doc COPYING should be moved to %license COPYING. Fixed. > [x]: Package does not own files or directories owned by other packages. > Note: Dirs in package are owned also by: > /usr/lib64/virt-p2v(virt-p2v-maker), > /usr/share/virt-p2v(virt-p2v-maker) > > I'm not very clear on what if anything f-r is complaining about here, > but I can see no actual problem with the %files section. I guess it found out that the existing virt-p2v-maker package also owns these directories. > [x]: Useful -debuginfo package or justification otherwise. > > It's a noarch package because it doesn't contain any ELF binaries which run > on the host. Right, and I added a comment about that in the spec file. > [-]: Package is not known to require an ExcludeArch tag. > > The package is ExclusiveArch: x86-64 because it only works on x86. Ditto. > virt-p2v.x86_64: W: self-obsoletion virt-p2v-maker < 1:1.41.5 obsoletes > virt-p2v-maker = 1:1.41.0-1.fc32 > > I believe this is actually a bug, of a sort. The problem is that we have > released virt-p2v with a lower version number than the old libguestfs > package. Hmm... the options I see are: 1) package the next virt-p2v upstream release (which will be 1.42.0) 2) bump the epoch 3) not add Provides: virt-p2v-maker until virt-p2v is >= 1.42.0 > virt-p2v.x86_64: E: non-executable-script /usr/share/virt-p2v/kiwi-config.sh > 644 /bin/bash > virt-p2v.x86_64: E: non-executable-script > /usr/share/virt-p2v/launch-virt-p2v 644 /bin/bash - > > These are real bugs. - kiwi-config.sh is a template of KIWI configuration, and the real configuration file is generated by virt-p2v-make-kiwi - launch-virt-p2v is either copied in the guest by virt-p2v-make-disk (and made executable), or embedded in the p2v.ks file created by virt-p2v-make-kickstart (which makes it executable) > virt-p2v.x86_64: E: incorrect-fsf-address /usr/share/virt-p2v/launch-virt-p2v > virt-p2v.x86_64: E: incorrect-fsf-address /usr/share/virt-p2v/p2v.ks.in > > Also possible bugs. Indeed -- sent an easy fix upstream: https://www.redhat.com/archives/libguestfs/2019-September/msg00079.html -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
