[Bug 1747552] Review Request: libdfp - Decimal Floating Point library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1747552

Artur Iwicki <fedora@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora@xxxxxxxxxx



--- Comment #1 from Artur Iwicki <fedora@xxxxxxxxxx> ---
>Group:		System Environment/Libraries
>BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
>[...]
>Group:		Development/Libraries
The Group and BuildRoot tags are not used in Fedora.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

>%install
>rm -rf $RPM_BUILD_ROOT
>[...]
>%clean
>rm -rf $RPM_BUILD_ROOT
Don't remove the buildroot during %install. The %clean section is not needed.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

>%install
>make install install_root=$RPM_BUILD_ROOT
You can probably use %{make_install} here.

>cd Build
>[...]
>cd ..
Maybe use pushd / popd instead?

You should also include the COPYING.txt file in %files (and mark it as
%license).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux