[Bug 1744249] Review Request: python2-pip - A tool for installing and managing Python 2 packages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1744249



--- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
This is this package:

$ rpm -qlp python2-pip-19.1.1-8.fc32.noarch.rpm | egrep 'bash(-|_)completion'
/etc/bash_completion.d
/etc/bash_completion.d/pip2


This is rawhide:

$ repoquery --repo=compose -l python3-pip | egrep 'bash(-|_)completion'
/usr/share/bash-completion
/usr/share/bash-completion/completions
/usr/share/bash-completion/completions/pip
/usr/share/bash-completion/completions/pip3
/usr/share/bash-completion/completions/pip3.8

$ repoquery --repo=compose -l python2-pip | egrep 'bash(-|_)completion'
/usr/share/bash-completion
/usr/share/bash-completion/completions
/usr/share/bash-completion/completions/pip2
/usr/share/bash-completion/completions/pip2.7


This package says:

# Note that with disabled python3, bashcomp2 will be disabled as well because
# bashcompdir will point to a different path than with python3 enabled.
%global bashcompdir %(b=$(pkg-config --variable=completionsdir bash-completion
2>/dev/null); echo ${b:-%{_sysconfdir}/bash_completion.d})
%if "%{bashcompdir}" != "%{_sysconfdir}/bash_completion.d"
%global bashcomp2 1
%endif



That is bacause the python3 package section has:

  BuildRequires:  bash-completion

I think we just need to add that and kill the %{_sysconfdir}/bash_completion.d
fallback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux