https://bugzilla.redhat.com/show_bug.cgi?id=1739290 --- Comment #6 from J. Scheurich <mufti11@xxxxxx> --- This only a informal review, i aam not in the packager group 8-( Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Permissions on files are set properly. Note: See rpmlint output See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_file_permissions ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Creative Commons Attribution Public License (v3.0) GPL (v2) GNU Lesser General Public License", "NTP License", "BSD (unspecified)", "BSD 3-clause "New" or "Revised" License", "GPL (v2 or later) (with incorrect FSF address)", "zlib/libpng license". 807 files have unknown license. Detailed output of licensecheck in /home/mufti/review-angband/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor, /usr/share/icons/hicolor/32x32/apps, /usr/share/icons/hicolor/32x32 [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 4 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in angband [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 18739200 bytes in /usr/share angband-4.1.3-4.fc31.x86_64.rpm:18739200 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: angband-4.1.3-4.fc31.x86_64.rpm angband-debuginfo-4.1.3-4.fc31.x86_64.rpm angband-debugsource-4.1.3-4.fc31.x86_64.rpm angband-4.1.3-4.fc31.src.rpm angband.x86_64: W: spelling-error Summary(en_US) roguelike -> rogue like, rogue-like, roguery angband.x86_64: W: spelling-error %description -l en_US roguelike -> rogue like, rogue-like, roguery angband.x86_64: W: non-standard-gid /usr/bin/angband angband angband.x86_64: E: setgid-binary /usr/bin/angband angband 2755 angband.x86_64: E: non-standard-executable-perm /usr/bin/angband 2755 angband.x86_64: W: non-standard-gid /var/games/angband angband angband.x86_64: E: non-standard-dir-perm /var/games/angband 775 angband.x86_64: W: non-standard-gid /var/games/angband/scores angband angband.x86_64: E: non-standard-dir-perm /var/games/angband/scores 2775 angband.x86_64: W: no-manual-page-for-binary angband angband.src: W: spelling-error Summary(en_US) roguelike -> rogue like, rogue-like, roguery angband.src: W: spelling-error %description -l en_US roguelike -> rogue like, rogue-like, roguery 4 packages and 0 specfiles checked; 4 errors, 8 warnings. Rpmlint (debuginfo) ------------------- Checking: angband-debuginfo-4.1.3-4.fc31.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). angband-debuginfo.x86_64: W: invalid-url URL: https://rephial.org/ <urlopen error [Errno -2] Name or service not known> angband-debugsource.x86_64: W: invalid-url URL: https://rephial.org/ <urlopen error [Errno -2] Name or service not known> angband.x86_64: W: spelling-error Summary(en_US) roguelike -> rogue like, rogue-like, roguery angband.x86_64: W: spelling-error %description -l en_US roguelike -> rogue like, rogue-like, roguery angband.x86_64: W: invalid-url URL: https://rephial.org/ <urlopen error [Errno -2] Name or service not known> angband.x86_64: W: non-standard-gid /usr/bin/angband angband angband.x86_64: E: setgid-binary /usr/bin/angband angband 2755 angband.x86_64: E: non-standard-executable-perm /usr/bin/angband 2755 angband.x86_64: W: non-standard-gid /var/games/angband angband angband.x86_64: E: non-standard-dir-perm /var/games/angband 775 angband.x86_64: W: non-standard-gid /var/games/angband/scores angband angband.x86_64: E: non-standard-dir-perm /var/games/angband/scores 2775 angband.x86_64: W: no-manual-page-for-binary angband 3 packages and 0 specfiles checked; 4 errors, 9 warnings. Source checksums ---------------- http://rephial.org/downloads/4.1/angband-4.1.3.tar.gz : CHECKSUM(SHA256) this package : 9402c4f8da691edbd4567a948c5663e1066bee3fcb4a62fbcf86b5454918406f CHECKSUM(SHA256) upstream package : 9402c4f8da691edbd4567a948c5663e1066bee3fcb4a62fbcf86b5454918406f Requires -------- angband (rpmlib, GLIBC filtered): /bin/sh config(angband) libX11.so.6()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libncursesw.so.6()(64bit) libtinfo.so.6()(64bit) rtld(GNU_HASH) shadow-utils xorg-x11-fonts-misc angband-debuginfo (rpmlib, GLIBC filtered): angband-debugsource (rpmlib, GLIBC filtered): Provides -------- angband: angband angband(x86-64) application() application(angband.desktop) config(angband) angband-debuginfo: angband-debuginfo angband-debuginfo(x86-64) debuginfo(build-id) angband-debugsource: angband-debugsource angband-debugsource(x86-64) Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09 Command line :/bin/fedora-review -n angband Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: R, Haskell, Ocaml, Java, SugarActivity, Perl, fonts, PHP, Python Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
