https://bugzilla.redhat.com/show_bug.cgi?id=1739290 J. Scheurich <mufti11@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mufti11@xxxxxx --- Comment #5 from J. Scheurich <mufti11@xxxxxx> --- This only a informal review, i aam not in the packager group 8-( [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. ... [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 18739200 bytes in /usr/share angband-4.1.3-4.fc31.x86_64.rpm:18739200 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines ... Rpmlint ------- Checking: angband-4.1.3-4.fc31.x86_64.rpm angband-debuginfo-4.1.3-4.fc31.x86_64.rpm angband-debugsource-4.1.3-4.fc31.x86_64.rpm angband-4.1.3-4.fc31.src.rpm angband.x86_64: W: spelling-error Summary(en_US) roguelike -> rogue like, rogue -like, roguery angband.x86_64: W: non-standard-gid /usr/bin/angband angband angband.x86_64: E: setgid-binary /usr/bin/angband angband 2755 angband.x86_64: E: non-standard-executable-perm /usr/bin/angband 2755 angband.x86_64: W: non-standard-gid /var/games/angband angband angband.x86_64: E: non-standard-dir-perm /var/games/angband 775 angband.x86_64: W: non-standard-gid /var/games/angband/scores angband angband.x86_64: E: non-standard-dir-perm /var/games/angband/scores 2775 angband.x86_64: W: no-manual-page-for-binary angband ... 4 packages and 0 specfiles checked; 4 errors, 8 warnings -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
