https://bugzilla.redhat.com/show_bug.cgi?id=1735762 --- Comment #5 from MUNEENDRA (Broadcom) <muneendra.kumar@xxxxxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #4) > - %global _sysdir usr/lib is not needed anymore > > - please separate your %changelog entries by a newline > > - the archive seems corrupted, please check the Source URL. Also if you > package the "master" tip, you should link to the commit: > > %global commit f6f9e112f016089709cfd15b33df5ab0996e5c08 > %global shortcommit %(c=%{commit}; echo ${c:0:7}) > %global snapshotdate 20190812 > > Name: fc_txptd > Version: 0.1 > Release: 1.%{snapshotdate}git%{shortcommit}%{?dist} > Summary: Fibrechannel transport daemon > > License: GPLv2+ > URL: https://github.com/brocade/bsn-fc-txptd/ > Source0: %{url}/archive/%{commit}/%{name}-%{shortcommit}.tar.gz > > […] > > %prep > %autosetup -n %{name}-%{commit} > > > Although you should tag a Release in Github, it would be better. Also you > shouldn't upload binaries like fc_txptd-0.1.tar.gz and > fc_txptd-0.1-1.fc28.src.rpm to your GIT repo. Upload them to 3rd party > hosting service if you need to reference them here. Hi Robert, Thanks for the review. As you mentioned above i have removed the fc_txptd-0.1.tar.gz and fc_txptd-0.1-1.fc28.src.rpm from the GIT repo. Sorry iam new to the packaging and have couple of queries on the same. In the below link it was mentioned that If you have no place to put your spec and SRPM then i can place the same in https://copr.fedorainfracloud.org. https://fedoraproject.org/wiki/Package_Review_Process As per the above doc i have created a project https://copr.fedorainfracloud.org/coprs/muneendra/fctxpd/ And build the package for few distributions. https://copr.fedorainfracloud.org/coprs/muneendra/fctxpd/build/998427/ Can i mention spec URL and SRPM URL as below . Is this right way. Spec URL: https://github.com/brocade/bsn-fc-txptd/blob/master/SPEC/fc_txptd.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/muneendra/fctxpd/srpm-builds/00998427/fc_txptd-0.1-1.20190813gitc195e67.fc28.src.rpm Any inputs here will help me a lot. Regards, Muneendra. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
