[Bug 1735762] Review Request: fctxpd- This daemon adds FC network intelligence in host and host intelligence in FC network

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1735762



--- Comment #4 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
 -  %global  _sysdir usr/lib is not needed anymore

 - please separate your %changelog entries by a newline

 - the archive seems corrupted, please check the Source URL. Also if you
package the "master" tip, you should link to the commit:

%global commit          f6f9e112f016089709cfd15b33df5ab0996e5c08
%global shortcommit     %(c=%{commit}; echo ${c:0:7})
%global snapshotdate    20190812

Name:           fc_txptd
Version:        0.1
Release:        1.%{snapshotdate}git%{shortcommit}%{?dist}
Summary:        Fibrechannel transport daemon

License:        GPLv2+
URL:            https://github.com/brocade/bsn-fc-txptd/
Source0:        %{url}/archive/%{commit}/%{name}-%{shortcommit}.tar.gz

[…]

%prep
%autosetup -n %{name}-%{commit}


Although you should tag a Release in Github, it would be better. Also you
shouldn't upload binaries like fc_txptd-0.1.tar.gz and
fc_txptd-0.1-1.fc28.src.rpm to your GIT repo. Upload them to 3rd party hosting
service if you need to reference them here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux