https://bugzilla.redhat.com/show_bug.cgi?id=1733175 --- Comment #4 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- > Why are CONTRIBUTING.md and README.md duplicated? They are both in the documentation directory and together with the Go files. They're marked as documentation in both places, which means that the library is supposed to work without them, so why do they need to be in the directory with the Go code? They don't, but the go list command used to detect Go files insist on keeping all *.md files with the code, it's upstream behavior. > RPMlint complains about a hidden file, .goipath. As I'm not familiar with Go I need to ask: Do things break if that file isn't hidden? AFAIK it's used to specify import path directory. > The general Packaging Guidelines say that "header only libraries" must provide "*-static". Is this not done for Go? I can imagine that it might be considered unnecessary if it's well known that all Go libraries are just source code, but the Golang guidelines don't say anything about this. It's not done for Go. > As a side note, assigning the URL field from a macro and writing the URL in a comment seems a little silly to me. It's very good to have the URL of the upstream site in the spec file, but since the URL is there anyway, why not keep it in the URL field? But this is prescribed by the policy that the FPC has approved, so it's not an issue for the review. The URL and the import path might differ, they are not always the same, one points to the forge, the other to the import path. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
