Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Net-IRC - Perl interface to the Internet Relay Chat protocol Alias: perl-Net-IRC https://bugzilla.redhat.com/show_bug.cgi?id=313271 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-10-01 22:02 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 57587a48ddece7a995c6b138003ee798 Net-IRC-0.75.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/01_minimal....ok All tests successful. Files=1, Tests=3, 0 wallclock secs ( 0.08 cusr + 0.01 csys = 0.09 CPU) + exit 0 + Package perl-Net-IRC-0.75-2.fc8 -> Provides: perl(Net::IRC) = 0.75 perl(Net::IRC::Connection) perl(Net::IRC::DCC) perl(Net::IRC::DCC::Accept) perl(Net::IRC::DCC::CHAT) perl(Net::IRC::DCC::Connection) perl(Net::IRC::DCC::GET) perl(Net::IRC::DCC::SEND) perl(Net::IRC::Event) perl(Net::IRC::EventQueue) perl(Net::IRC::EventQueue::Entry) Requires: perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(IO::File) perl(IO::Select) perl(IO::Socket) perl(IO::Socket::INET) perl(Net::IRC::Connection) perl(Net::IRC::DCC) perl(Net::IRC::Event) perl(Net::IRC::EventQueue) perl(Net::IRC::EventQueue::Entry) perl(Socket) perl(Symbol) perl(strict) perl(subs) perl(vars) perl(warnings) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review