https://bugzilla.redhat.com/show_bug.cgi?id=1725924 Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #8 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Ha, no worries Antonio, please feel free to provide comments too :) Here are some preliminary notes too. The scratch build succeeds: https://koji.fedoraproject.org/koji/taskinfo?taskID=36021962 rpmlint picks up a few important things that need looking into. `rpmlint -i` would give more verbose results: /home/asinha/rpmbuild/SPECS/pveclib.spec:1: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 1) ^ Please use either spaces or tabs, it's just good to be consistent. pveclib.src: W: spelling-error %description -l en_US intrinsics -> intrinsic, intrinsic s, extrinsic pveclib.src: W: spelling-error %description -l en_US altivec -> elective ^ Can be ignored. pveclib.src: W: invalid-license APACHE ^ The License is OK, but the right name needs to be picked for the specfile. Please have a look here: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses pveclib.ppc64le: W: incoherent-version-in-changelog 1.0.2 ['1.0.2-7.fc31', '1.0.2-7'] ^ The changelog must reflect the version/release correctly. https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs You can start with the Release as 1 here. That only needs to be bumped when the spec is changed and a new build is to be made. pveclib.ppc64le: E: shared-lib-without-dependency-information /usr/lib64/libpvec.so.0.0.0 ^ Will have to look deeper to see what this one is about. pveclib.ppc64le: W: dangling-relative-symlink /usr/share/licenses/pveclib/COPYING LICENSE ^ Please fix this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
