[Bug 1714377] Review Request: ansible-bender - build container images using ansible playbooks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1714377



--- Comment #21 from Gordon Messmer <gordon.messmer@xxxxxxxxx> ---
Spec URL:
https://bitbucket.org/gordonmessmer/ansible-bender/raw/f0e302132eb77f95e2a6843040a75fcd78a7987b/ansible-bender.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/1047/36011047/ansible-bender-0.6.1-6.fc30.src.rpm

> 1) The actual license seems to be MIT, not GPLv3.

I have no idea how I managed to get that wrong.

> 2) There are no versions in %changelog.

Fixed.

> 3) please see why ansible_bender/version.py is empty.

The last commit to that file appears to have emptied it but not removed it:
https://github.com/ansible-community/ansible-bender/commit/e4159777668b373affb3ddaf2500d31237b1683f#diff-bb005fcc244a54d88969f0181c8ec18e

I'm unsure why the author might leave the file present, but I can ask them if
the answer is important.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux