https://bugzilla.redhat.com/show_bug.cgi?id=1717389 Neal Gompa <ngompa13@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@xxxxxxxxx --- Comment #5 from Neal Gompa <ngompa13@xxxxxxxxx> --- 1. "%{rpmmacrodir}" is undefined. It's "%{_rpmmacrodir}": https://github.com/rpm-software-management/rpm/blob/master/macros.in#L141-L142 2. Please include a license file, because other distros will copy these macros (Mageia and OpenMandriva, for example, source from us) and it's easier to comply with licenses when they exist in the source tree. 3. Please use "python3dist(pip)" or "python3-pip" instead of "pip" as a dependency. "pip" doesn't exist. 4. The %build section sets up %_builddir and %_buildsubdir, so don't drop it, just put a comment indicating there's nothing to do there. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
