[Bug 1717389] Review Request: pyproject-rpm-macros - adds macros using pip to build wheels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1717389



--- Comment #4 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
Thanks.

11. Have you actually tried to install this package? It will probably fail as
there is no "pip" package.

12. Please use the %{rpmmacrodir} consistently (i.e. also in %files).

13. Remove the brackets from [PEP 517] 

15. you can drop the empty %build section

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux