[Bug 1720949] Review Request: NZBGet - A very efficient Usenet Downloader

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1720949



--- Comment #5 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
(In reply to Chris Caron from comment #4)
> Thanks again for such a speedy response; I addressed all your concerns but a
> few:
> 
> >  unrar is not available in Fedora, only rpmfusion. Are you sure is is mandatory?
> 
> Unfortunately it is; just about all binary postings on Usenet require to be
> unrar'ed.  Do you foresee this as a problem? I forgot about unrar's strange
> license causing it to sit in other repo's. I also found this link
> https://fedoraproject.org/wiki/Licensing:Unrar.
> 

The program will function without unrar, yes? You could change the Requires to
a Recommends:
Otherwise this program won't be allowed in Fedora, you would need to propose it
to RPMFusion, as it depends on unrar.

> > nzbget.x86_64: W: log-files-without-logrotate ['/var/log/nzbget']
> 
> The out-of-the-box nzbget configuration has log rotate already built into
> it. The daemon itself does the log rotating.  Should I patch the
> configuration file to not do this by default and provide a logrotate?  Or is
> it acceptable as it is?
> 
It should be ok.

> >  - Notify upstream about the wrong FSF address:
> 
> Done; i did a pull request for the next release and created a small patch
> file for this one.
> Source: https://github.com/nzbget/nzbget/pull/648
> 
> > nzbget.x86_64: E: non-readable /etc/nzbget.conf 640
> 
> 
> I cleaned up most of these entries and changed this one to just read 660
> which may still trigger this error.  The big problem is this file contains
> passwords in clear text, so I'd like the file to be as restricted as
> possible and only accessible by the nzbget user and root. I strongly advise
> keeping the 'other user without write/read permissions here.  Is this okay? 
> Perhaps you have a better suggestion for this?
> 
Ignore this f-r error, permissions are ok.

> As for the content you're interested in:
> spec:
> https://copr-be.cloud.fedoraproject.org/results/lead2gold/nzbget/fedora-
> rawhide-x86_64/00942866-nzbget/nzbget.spec
> srpm:
> https://copr-be.cloud.fedoraproject.org/results/lead2gold/nzbget/fedora-
> rawhide-x86_64/00942866-nzbget/nzbget-21.0-1.fc31.src.rpm
> 
> 
> Chris

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux