[Bug 1713315] Review Request: perl-AnyEvent-HTTP-Server - AnyEvent HTTP/1.1 Server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1713315



--- Comment #3 from Yanko Kaneti <yaneti@xxxxxxxxxxx> ---
Thanks for the review and sorry for having so many issues to begin with.
I've followed most of your recommendation except (maybe the most important one
;): 

- > The upstream calls the software AnyEvent-HTTP-Server-II. Name this package
perl-AnyEvent-HTTP-Server-II. There is no reason for diverging.

I think the only reason there is a -II repository is for the authors desire to
stress that the module has been mostly rewritten.
For all other intents and purposes this is perl-AnyEvent-HTTP-Server version
2.0 (a 1.9... prerelease) and the name conflict is intentional, even the readme
says so.


- TODO: Remove the unversioned dependencies on 'perl(AnyEvent)',
'perl(Digest::SHA1)', and 'perl(JSON::XS)'. They are redundant.

This sounds to me like a regression in rpm-build, the release notes for rpm
4.13 explicitly say "Filter automatic unversioned dependencies when versioned
ones exist (RhBug:678605)" with rationale being a perl related bug



-3
Incorporate review feedack (#1713315)

Spec URL:
http://declera.com/~yaneti/perl-AnyEvent-HTTP-Server/perl-AnyEvent-HTTP-Server.spec
SRPM URL:
http://declera.com/~yaneti/perl-AnyEvent-HTTP-Server/perl-AnyEvent-HTTP-Server-1.99981-3.20190523gitb09c2c7.fc31.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux