https://bugzilla.redhat.com/show_bug.cgi?id=1713315 --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> --- FIX: The upstream calls the software AnyEvent-HTTP-Server-II. Name this package perl-AnyEvent-HTTP-Server-II. There is no reason for diverging. Url and Source addresses are Ok. Source archive (SHA-256: 461a4f3bc3897ab9e26cf3f0db51d193370f150fe95dce3daf1a65f8e19f7542) is original. Ok. TODO: Remove a Group tag. It should not be used in Fedora. License verified from lib/AnyEvent/HTTP/Server/Req.pm, lib/AnyEvent/HTTP/Server.pm, README, Makefile.PL, LICENSE. Ok. FIX: Build-require 'perl-interpreter' (perl-AnyEvent-HTTP-Server.spec:29). TODO: You should use plain 'perl' commands instead of '%{__perl}' macro. FIX: Build-require 'make' (perl-AnyEvent-HTTP-Server.spec:41). FIX: Either build-require findutils (perl-AnyEvent-HTTP-Server.spec:46), or build-require 'perl(ExtUtils::MakeMaker) >= 6.76' and supply 'NO_PACKLIST=1 NO_PERLLOCAL=1' arguments Makefile.PL. Then you don't have to run the two find commands and instead of 'make pure_install...' you can just call '%{make_install}'. TODO: Use '%{make_build} instead of 'make %{?_smp_mflags}'. TODO: Do not package META.json file. It does not bring any new data to the users. TODO: Package 'ex' directory as a documentation. TODO: Unset AUTHOR environment variable before runnig Makefile.PL. Otherwise the build would require additional dependencies. FIX: Build-require 'perl(:VERSION) >= 5.10' (lib/AnyEvent/HTTP/Server/WS.pm:3). FIX: Build-require 'perl(Data::Dumper)', 'perl(feature)', 'perl(strict)','perl(utf8)', 'perl(warnings)' (Kit.pm.PL). FIX: Build-require 'perl(AnyEvent::Handle)' (t/01-basic.t:7). FIX: Build-require 'perl(AnyEvent::Socket)' (t/01-basic.t:6). FIX: Build-require 'perl(Test::More)' (COMPILE t/01-basic.t:11). FIX: Build-require 'perl(AnyEvent::Util) (lib/AnyEvent/HTTP/Server.pm:28). FIX: Build-require 'perl(Config)' (lib/AnyEvent/HTTP/Server/WS.pm:7). FIX: Build-require 'prl(constant)' (lib/AnyEvent/HTTP/Server/Req.pm:57). FIX: Build-require 'perl(Encode)' (lib/AnyEvent/HTTP/Server.pm:31). FIX: Build-require 'perl(MIME::Base64)' (lib/AnyEvent/HTTP/Server.pm:33). FIX: Build-require 'perl(overload)' (lib/AnyEvent/HTTP/Server/Req.pm:19). FIX: Build-require 'perl(Scalar::Util)' (lib/AnyEvent/HTTP/Server.pm:26). FIX: Build-require 'perl(Socket)' (lib/AnyEvent/HTTP/Server.pm:29). FIX: Build-require 'perl(Time::HiRes) (lib/AnyEvent/HTTP/Server.pm:34). $ rpmlint perl-AnyEvent-HTTP-Server.spec ../SRPMS/perl-AnyEvent-HTTP-Server-1.99981-2.20190523gitb09c2c7.fc31.src.rpm ../RPMS/noarch/perl-AnyEvent-HTTP-Server-1.99981-2.20190523gitb09c2c7.fc31.noarch.rpm /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') /usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751 s.decode('UTF-8') 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-AnyEvent-HTTP-Server-1.99981-2.20190523gitb09c2c7.fc31.noarch.rpm drwxr-xr-x 2 root root 0 Jun 6 16:24 /usr/share/doc/perl-AnyEvent-HTTP-Server -rw-r--r-- 1 root root 525 Oct 28 2018 /usr/share/doc/perl-AnyEvent-HTTP-Server/Changes -rw-r--r-- 1 root root 941 Oct 28 2018 /usr/share/doc/perl-AnyEvent-HTTP-Server/META.json -rw-r--r-- 1 root root 2551 Oct 28 2018 /usr/share/doc/perl-AnyEvent-HTTP-Server/README.md drwxr-xr-x 2 root root 0 Jun 6 16:24 /usr/share/licenses/perl-AnyEvent-HTTP-Server -rw-r--r-- 1 root root 157 Oct 28 2018 /usr/share/licenses/perl-AnyEvent-HTTP-Server/LICENSE -rw-r--r-- 1 root root 3374 Jun 6 16:24 /usr/share/man/man3/AnyEvent::HTTP::Server.3pm.gz -rw-r--r-- 1 root root 3037 Jun 6 16:24 /usr/share/man/man3/AnyEvent::HTTP::Server::Req.3pm.gz drwxr-xr-x 2 root root 0 Jun 6 16:24 /usr/share/perl5/vendor_perl/AnyEvent drwxr-xr-x 2 root root 0 Jun 6 16:24 /usr/share/perl5/vendor_perl/AnyEvent/HTTP drwxr-xr-x 2 root root 0 Jun 6 16:24 /usr/share/perl5/vendor_perl/AnyEvent/HTTP/Server -rw-r--r-- 1 root root 31675 Oct 28 2018 /usr/share/perl5/vendor_perl/AnyEvent/HTTP/Server.pm -rw-r--r-- 1 root root 2713 Jun 6 16:24 /usr/share/perl5/vendor_perl/AnyEvent/HTTP/Server/Kit.pm -rw-r--r-- 1 root root 20105 Oct 28 2018 /usr/share/perl5/vendor_perl/AnyEvent/HTTP/Server/Req.pm -rw-r--r-- 1 root root 8958 Oct 28 2018 /usr/share/perl5/vendor_perl/AnyEvent/HTTP/Server/WS.pm File permissions and locations are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-AnyEvent-HTTP-Server-1.99981-2.20190523gitb09c2c7.fc31.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.30.0) 1 perl(:VERSION) >= 5.10.0 1 perl(AnyEvent) 1 perl(AnyEvent) >= 5 1 perl(AnyEvent::Handle) 1 perl(AnyEvent::HTTP::Server::Kit) 1 perl(AnyEvent::HTTP::Server::Req) 1 perl(AnyEvent::HTTP::Server::WS) 1 perl(AnyEvent::Socket) 1 perl(AnyEvent::Util) 1 perl(Compress::Zlib) 1 perl(Config) 1 perl(constant) 1 perl(Data::Dumper) 1 perl(Digest::SHA1) 1 perl(Digest::SHA1) >= 2 1 perl(Encode) 1 perl(Errno) 1 perl(JSON::XS) 1 perl(JSON::XS) >= 3 1 perl(MIME::Base64) 1 perl(overload) 1 perl(Scalar::Util) 1 perl(Socket) 1 perl(strict) 1 perl(Time::HiRes) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 TODO: Remove the unversioned dependencies on 'perl(AnyEvent)', 'perl(Digest::SHA1)', and 'perl(JSON::XS)'. They are redundant. $ rpm -q --provides -p ../RPMS/noarch/perl-AnyEvent-HTTP-Server-1.99981-2.20190523gitb09c2c7.fc31.noarch.rpm | sort -f | uniq -c 1 perl(AnyEvent::HTTP::Server) = 1.99981 1 perl(AnyEvent::HTTP::Server::Form) = 1.97 1 perl(AnyEvent::HTTP::Server::Kit) 1 perl(AnyEvent::HTTP::Server::Req) 1 perl(AnyEvent::HTTP::Server::WS) 1 perl(AnyEvent::HTTP::Server::WS::CLOSING) 1 perl-AnyEvent-HTTP-Server = 1.99981-2.20190523gitb09c2c7.fc31 Binary provides are Ok. $ resolvedeps f31-build ../RPMS/noarch/perl-AnyEvent-HTTP-Server-1.99981-2.20190523gitb09c2c7.fc31.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in F31 (https://koji.fedoraproject.org/koji/taskinfo?taskID=35338134). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file. Resolution: NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
