[Bug 1717652] Review Request: prusa-slicer - G-code generator for 3D printers (RepRap, Makerbot, Ultimaker etc.)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1717652



--- Comment #3 from Jason Tibbitts <tibbs@xxxxxxxxxxx> ---
> This comment can go away now I suppose.

You're right, fixed.

> Who owns %_datadir/PrusaSlicer ?

Indeed, %dir added there.  I'd forgotten it when setting up the %lang tagging.

> Why si this commented out? The tests started to work again?

The upstream bug was fixed and I cherry picked the patch.  Forgot to remove
that bit after verifying that the patch worked.  The bug I filed generated some
interesting discussion as it found a real bug but they claim that we shouldn't
be turning on the compiler flag that found the bug because it's a performance
loss.  It's a Fedora-default flag, not something specifically done in this
package.

I've updated the package to release 2:

Spec: https://www.math.uh.edu/~tibbs/review/prusa-slicer/prusa-slicer.spec
SRPM:
https://www.math.uh.edu/~tibbs/review/prusa-slicer/prusa-slicer-2.0.0-2.fc31.src.rpm
Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=35320754 (will take
some time to finish)

I still need to cherry pick a few patches to fix some minor interface bugs, but
that will be a work in progress thing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux