https://bugzilla.redhat.com/show_bug.cgi?id=1713067 --- Comment #6 from David Shea <dshea@xxxxxxxxxx> --- Created attachment 1572598 --> https://bugzilla.redhat.com/attachment.cgi?id=1572598&action=edit review.txt Attached the review. Just two minor things to note: 1) The thing about parallel make. What this really means now is that %build doesn't need the `make clean` line. It can be replaced with, e.g., "# Nothing to build" or some placeholder along those lines 2) The thing about %define. Since it's noarch the spec file doesn't need the debug_package override anymore. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
