https://bugzilla.redhat.com/show_bug.cgi?id=1707080 --- Comment #5 from Petr Menšík <pemensik@xxxxxxxxxx> --- (In reply to Jaroslav Škarvada from comment #3) > (In reply to Petr Menšík from comment #2) > > Hopefully all fixed. > > > * File /usr/lib/udev/rules.d/10-osmo-fl2k.rules is shipped, but its > > directory is not owned by package or required by the package (systemd-udev > > or kexec-tools). > > > I think this is not needed [1] > > [1] > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > #_the_directory_is_owned_by_a_package_which_is_not_required_for_your_package_ > to_function In that example, it says exactly what I mentioned. You might not use Requires, but still have to own that directory in your package. Unowned directory is not permitted, even for optional content. Solution: the evolution package should own the /usr/share/gtk-doc directory. There is no need to add an explicit Requires on gtk-doc solely for the directory ownership. Also, now we have separate libs subpackage, but it has not license file inside and does not depend on any package that has it. I suggest moving %license to libs, it should be required explicitly from other subpackages then. Licensecheck also mentions other licenses than GPLv2+: GNU Lesser General Public License (v2.1 or later) ------------------------------------------------- osmo-fl2k-0.1.1-df33203d/src/getopt/getopt.c osmo-fl2k-0.1.1-df33203d/src/getopt/getopt.h GPL (v3 or later) ----------------- osmo-fl2k-0.1.1-df33203d/cmake/Modules/Version.cmake osmo-fl2k-0.1.1-df33203d/include/rds_mod.h osmo-fl2k-0.1.1-df33203d/src/rds_mod.c getopt seems not used by our compilation, but rds_mod is. I think Licenses: GPLv2+ and GPLv3+ should be used. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
