https://bugzilla.redhat.com/show_bug.cgi?id=1701567 --- Comment #5 from Xavier Bachelot <xavier@xxxxxxxxxxxx> --- (In reply to Adam Borowski from comment #4) > Spec URL: https://angband.pl/tmp/fedora/colorized-logs.spec > SRPM URL: https://angband.pl/tmp/fedora/colorized-logs-2.4-1.fc30.src.rpm > > Done, other than for bumping release/changelog -- should they keep trace of > any in-review version that hasn't been committed to any public repository? > This would pollute the final package with WIP changes. But perhaps I'm > wrong with applying the reasoning I'm used to in Debian to Fedora workflows? > The diff from previous attempt is whitespace only, so there are no real > changes to mention in this case. Is this good enough for now? > It doesn't matter that much for simple package like this one, where the changes pointed out by the review are simple as well and easy to verify, but for more complicated packages and more involved changes, the reviewer needs to be able to examine carefully the changes. Thus it is good habit to always bump the release and add a changelog entry, even at review time. > > For the other package (vmemcache): fedora-scm-requests got denied because > "review is approved by a user that is not a packager", thus I guess it needs > to be seen by someone with actual privileges. It's too early for the scm request, you need to be sponsored first (and that's why the request failed, you are not in the packager group yet). That's why I (and Bob in the vmemcache review) asked for more packages from you or that you make informal reviews of other packages submissions. We both can sponsor you, just show us your skills and that will happen :-) I haven't run fedora-review yet on this package, but I expect the result to be clean and there are good chances I would approve it after. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
