[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1665749

Dhanesh B. Sabane <dhanesh95@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(zbyszek@xxxxxxxxx
                   |                            |)



--- Comment #15 from Dhanesh B. Sabane <dhanesh95@xxxxxxxxxxx> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #14)
> rpmlint:
> python3-pipreqs.noarch: E: wrong-script-interpreter
> /usr/lib/python3.7/site-packages/pipreqs/pipreqs.py /usr/bin/env python
> python3-pipreqs.noarch: E: non-executable-script
> /usr/lib/python3.7/site-packages/pipreqs/pipreqs.py 644 /usr/bin/env python

I believe these errors are due to the shebang lines. But I do have a small
piece of code in the '%prep' section that should handle this case. I'm not sure
why it's still an issue. Will you please help me resolve this?

> python3-pipreqs.noarch: W: spurious-executable-perm
> /usr/share/man/man1/pipreqs.1.gz
> 

I'm thinking this can be fixed using '%defattr' in the '%files' section. Is
that an acceptable fix?

> Those are not very important, but correct. Please consider fixing them.
> 
> Package is APPROVED.

Thanks! I'll resolve the previous issues before pushing the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux