https://bugzilla.redhat.com/show_bug.cgi?id=1665749 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review+ --- Comment #14 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- This library generates a 'requirements.txt' file for any project → This library generates a 'requirements.txt' file for any Python project BuildRequires (and other dependencies) should be one-per-line: BuildRequires: %{py3_dist docopt setuptools yarg sphinx} → BuildRequires: %{py3_dist docopt} BuildRequires: %{py3_dist setuptools} ... + package name is OK (and subpackages too) + license is acceptable for Fedora (ASL 2) + license is specified correctly + latest version (upstream seems to have tagged 0.4.7 as the latest, but has 0.4.8 in the changelog, and 0.4.9 on pypi.) + builds and installs OK + requires/provides look OK rpmlint: python3-pipreqs.noarch: E: wrong-script-interpreter /usr/lib/python3.7/site-packages/pipreqs/pipreqs.py /usr/bin/env python python3-pipreqs.noarch: E: non-executable-script /usr/lib/python3.7/site-packages/pipreqs/pipreqs.py 644 /usr/bin/env python python3-pipreqs.noarch: W: spurious-executable-perm /usr/share/man/man1/pipreqs.1.gz Those are not very important, but correct. Please consider fixing them. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
