Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fedora-screensaver-theme - Fedora screensaver theme https://bugzilla.redhat.com/show_bug.cgi?id=305771 mclasen@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ ------- Additional Comments From mclasen@xxxxxxxxxx 2007-09-26 19:23 EST ------- rpmlint output: /var/lib/mock/fedora-development-i386/result/fedora-screensaver-theme-1.0.0-1.fc8.noarch.rpm fedora-screensaver-theme.noarch: W: invalid-license GPL fedora-screensaver-theme.noarch: E: invalid-desktopfile /usr/share/applications/screensavers/system.desktop package name: ok spec file name: ok packaging guidelines: see above, the desktop file should be fixed by adding a semicolon at the end of the Categories list license: ok license field: must be fixed license file: ok spec language: ok spec legibility: ok upstream sources: no upstream yet buildable: yes ExcludeArch: n/a relocatable: n/a directory ownership: ok %files: ok permissions: ok %clean: ok macro use: consistent content: permissible large docs: n/a %doc: ok headers: n/a static libs: n/a pc files: n/a shared libs: n/a libtool archives: ok gui apps: n/a directories: ok %install: ok utf8 filenames: ok Fix the license and the desktop file, then it is approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review