https://bugzilla.redhat.com/show_bug.cgi?id=1697631 Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #8 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #7) > (In reply to Ankur Sinha (FranciscoD) from comment #6) > > A couple of issues: > > > > - snapshot info must be included in release > > Snapshot info is computed automatically by macros in %dist. > https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/forge. > lua#_196 Has this been announced? It's getting rather hard to keep track of all this automation unless one keeps an eye on the sources---which is not ideal at all. Nothing here: https://docs.fedoraproject.org/en-US/packaging-guidelines/DistTag/ or here: https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots > > > - not sure about build flags being used in the compile step > > The macro %gobuild contains Fedora build flags: > > + go build -buildmode pie -compiler gc '-tags=rpm_crashtraceback ' -ldflags > ' -X > github.com/xordataexchange/crypt/version. > commit=b2862e3d0a775f18c7cfe02273500ae307b61218 -X > github.com/xordataexchange/crypt/version=0.0.2 -B > 0x3a858e85ef5d9325eb4458aa84bd3d84f2dfe986 -extldflags '\''-Wl,-z,relro > -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld > '\''' -a -v -x -o _bin/crypt github.com/xordataexchange/crypt/bin/crypt/ > > > - does -devel not need to require the base package in golang? > > > > No. The binary can complement the devel package but it's not a hard > dependency, there's nothing compiled in the devel package, it's just noarch > source files. I expect this will be documented in the golang guidelines whenever they make it to docs? In the meantime, approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
