[Bug 1697631] Review Request: golang-github-xordataexchange-crypt - Store and retrieve encrypted configs from etcd or consul

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1697631



--- Comment #7 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
(In reply to Ankur Sinha (FranciscoD) from comment #6)
> A couple of issues:
> 
> - snapshot info must be included in release

Snapshot info is computed automatically by macros in %dist.
https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/forge.lua#_196

> - not sure about build flags being used in the compile step

The macro %gobuild contains Fedora build flags:

+ go build -buildmode pie -compiler gc '-tags=rpm_crashtraceback ' -ldflags '
-X
github.com/xordataexchange/crypt/version.commit=b2862e3d0a775f18c7cfe02273500ae307b61218
-X github.com/xordataexchange/crypt/version=0.0.2 -B
0x3a858e85ef5d9325eb4458aa84bd3d84f2dfe986 -extldflags '\''-Wl,-z,relro
-Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '\'''
-a -v -x -o _bin/crypt github.com/xordataexchange/crypt/bin/crypt/

> - does -devel not need to require the base package in golang?
> 

No. The binary can complement the devel package but it's not a hard dependency,
there's nothing compiled in the devel package, it's just noarch source files.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux