[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #18 from Petr Menšík <pemensik@xxxxxxxxxx> ---
(In reply to Kim Walisch from comment #16)
> > The primesieve GUI application does not work properly using Qt5.
> 
> Actually I have now retested this on Ubuntu 18.04 with GNOME and it works
> fine. So the Qt5 issue I mentioned before only affects Windows as I have
> implemented a workaround that works fine on Linux (but not on Windows). The
> primesieve GUI application also does also not work properly using the
> Ubuntu's Unity desktop (that has recently been deprecated).
> 
> Personally I would prefer not to include the primesieve GUI application
> because ensuring it works fine on all the different desktop spins is a bit
> of a nightmare...

Ok. It seems to me you use some unportable behaviour that makes you application
unstable. I think printProcessOutput() should emit signals with new values and
should not even try to call processEvents or manually redraw. Instead, it
should run in worker thread and timer should periodically redraw new results,
until job is finished. processEvents should be only the main one for your
applications, other should use signal-slot connections processed from main
loop. No main thread blocking should occur. Stackoverflow might help [1]

Anyway, no problem with not packaging it if you think it is not ready. Worked
to me yesteray without any crash.

1.
https://stackoverflow.com/questions/14545961/modify-qt-gui-from-background-worker-thread

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux