https://bugzilla.redhat.com/show_bug.cgi?id=1540335 --- Comment #17 from Petr Menšík <pemensik@xxxxxxxxxx> --- (In reply to Kim Walisch from comment #15) > > Other than these few issues, package is ready to be packaged in Fedora. Good job for first package! > > Thanks! I will fix the issues you have pointed out. > > > 3) Unless there is expected usage of static libraries, that offers significant speed advantage, I would omit static subpackage. It requires explicit exception and I doubt it is required. Use rm to remove *.la in %build or %install phase. [1] > > If I build using 'cmake . -DBUILD_STATIC_LIBS=OFF' do I still need to do > "Use rm to remove *.la in %build or %install phase"? Anything that prevents installation (or build) of static libraries is okay. Your solution is clearer, happy with that. rm is suggested only because it always work, even without support in build system. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
