https://bugzilla.redhat.com/show_bug.cgi?id=1540335 --- Comment #15 from Kim Walisch <kim.walisch@xxxxxxxxx> --- > Other than these few issues, package is ready to be packaged in Fedora. Good job for first package! Thanks! I will fix the issues you have pointed out. > 3) Unless there is expected usage of static libraries, that offers significant speed advantage, I would omit static subpackage. It requires explicit exception and I doubt it is required. Use rm to remove *.la in %build or %install phase. [1] If I build using 'cmake . -DBUILD_STATIC_LIBS=OFF' do I still need to do "Use rm to remove *.la in %build or %install phase"? > Just a question, it has also working GUI with a different license (GPLv3). Is there some reason why gui variant is not packaged? The reason why the GUI version is e.g. not packaged in Debian and Homebrew is because it depends on Qt4 and does not work properly using Qt5. Qt4 allows signal recursion (see https://github.com/kimwalisch/primesieve/blob/master/src/gui/src/PrimeSieveGUI.cpp#L301) which primesieve depends upon while Qt5 does not. Using Qt5 the primesieve GUI application often crashes after running it for just a few seconds. I have already tried to find a workaround for this issue in the past but I have not succeeded. That's why primesieve is stuck with Qt4. If we would include the primesieve GUI application into the Fedora package this would cause issues once Qt4 will be deprecated. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
