[Bug 1691947] Review Request: umr - AMDGPU Userspace Register Debugger

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1691947



--- Comment #2 from Jeremy Newton <alexjnewt@xxxxxxxxxxxx> ---
Thanks for the review!

Sorry for the delay, I've been pretty busy.

> The package is not installable

Yes this looks like there was a bug in the cmake file. Libumrapp should be a
statically compiled into the umr binary, not a shared library.
I've worked with upstream to fix this issue. My patch is now upstream so this
should be fixed.

> Provides umr-static for your devel package containing static lib

Done, thanks!

I've updated the git snapshot. I also dropped my patches as they have been
pulled into upstream master.

New files:
Spec URL: https://mystro256.fedorapeople.org/umr.spec
SRPM URL:
https://mystro256.fedorapeople.org/umr-1.0-2.20190403.git1139876.fc29.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux