https://bugzilla.redhat.com/show_bug.cgi?id=1695139 --- Comment #3 from Carmen Bianca Bakker <carmenbianca@xxxxxxxxxxxxxxxxx> --- Thanks for the quick review. (In reply to Miro Hrončok from comment #2) > > # Don't use py3_build because it doesn't work > > How? Define doesn't work. I could add the explanation to the specfile, but it's basically as follows. py3_build is defined as such: carmen@carmen-thinkpad ~ $ rpm --showrc | grep -A4 py3_build -13: py3_build %{expand:\ CFLAGS="${CFLAGS:-${RPM_OPT_FLAGS}}" LDFLAGS="${LDFLAGS:-${RPM_LD_FLAGS}}"\ %{__python3} %{py_setup} %{?py_setup_args} build --executable="%{__python3} %{py3_shbang_opts}" %{?*} sleep 1 } Note the `--executable` flag. This becomes `/usr/bin/python3 -s`. xonsh takes this and rewrites the shebangs in its script files (e.g., /usr/bin/xonsh) using this executable. This becomes: #!/usr/bin/python3 -s -u Which, when executed, fails. I could alter %{py3_shbang_opts}, but frankly I don't know how to do that. > > %prep > > # Remove bundled egg-info > > rm -rf xonsh.egg-info > > > > %autosetup -n %{name}-%{version} > > Removing anything before %setup or %autosetup makes no sense. It doesn't > abort the build because rm -f doesn't fail on missing file, but it has no > meaning. Agreed and removed. It's a leftover from the previous maintainer. > > %{python3_sitelib}/xonsh > > %{python3_sitelib}/xontrib > > %{python3_sitelib}/xonsh-%{version}-py?.?.egg-info > > Please add trialing slashes for directories, see > https://lists.fedoraproject.org/archives/list/python-devel@lists. > fedoraproject.org/message/BJPQFQ2TORLZOWQRZ6DGWUIA4T5AS63A/ > > > > Note: Since this package tries to use setuptools if they are present, you > better BR python3-setuptools directly in case it is not automatically > transitively pulled by python3-devel, in order to make the build more > deterministic. See also > https://src.fedoraproject.org/rpms/python3/blob/master/f/python3.spec#_402 > (line 402). Done and done. Spec URL: https://gitlab.com/snippets/1842176/raw SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/1411/33911411/xonsh-0.8.12-1.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
