[Bug 1695139] Review Request: xonsh - A general purpose, Python-ish shell

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1695139



--- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
> # Don't use py3_build because it doesn't work

How? Define doesn't work.



> %prep
> # Remove bundled egg-info
> rm -rf xonsh.egg-info
> 
> %autosetup -n %{name}-%{version}

Removing anything before %setup or %autosetup makes no sense. It doesn't abort
the build because rm -f doesn't fail on missing file, but it has no meaning.


> %{python3_sitelib}/xonsh
> %{python3_sitelib}/xontrib
> %{python3_sitelib}/xonsh-%{version}-py?.?.egg-info

Please add trialing slashes for directories, see
https://lists.fedoraproject.org/archives/list/python-devel@xxxxxxxxxxxxxxxxxxxxxxx/message/BJPQFQ2TORLZOWQRZ6DGWUIA4T5AS63A/



Note: Since this package tries to use setuptools if they are present, you
better BR python3-setuptools directly in case it is not automatically
transitively pulled by python3-devel, in order to make the build more
deterministic. See also
https://src.fedoraproject.org/rpms/python3/blob/master/f/python3.spec#_402
(line 402).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux