https://bugzilla.redhat.com/show_bug.cgi?id=1691022 Numan Siddique <numan.siddique@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(zebob.m@xxxxxxxxx | |) --- Comment #15 from Numan Siddique <numan.siddique@xxxxxxxxx> --- (In reply to Numan Siddique from comment #14) > (In reply to Robert-André Mauchin from comment #12) > > - Add BR for gcc > > > > - Update License field > > > > > > BSD 3-clause "New" or "Revised" License > > --------------------------------------- > > openvswitch-2.11.0/include/sparse/rte_byteorder.h > > openvswitch-2.11.0/include/sparse/rte_esp.h > > openvswitch-2.11.0/include/sparse/rte_flow.h > > openvswitch-2.11.0/include/windows/netinet/icmp6.h > > openvswitch-2.11.0/include/windows/netinet/ip6.h > > openvswitch-2.11.0/lib/strsep.c > > openvswitch-2.11.0/tests/dpdk/ring_client.c > > > > BSD 4-clause "Original" or "Old" License > > ---------------------------------------- > > openvswitch-2.11.0/include/sparse/rte_icmp.h > > openvswitch-2.11.0/include/sparse/rte_ip.h > > openvswitch-2.11.0/include/sparse/rte_sctp.h > > openvswitch-2.11.0/include/sparse/rte_tcp.h > > openvswitch-2.11.0/include/sparse/rte_udp.h > > > > Expat License > > ------------- > > openvswitch-2.11.0/build-aux/install-sh > > openvswitch-2.11.0/include/openflow/openflow-1.3.h > > openvswitch-2.11.0/include/openflow/openflow-1.4.h > > openvswitch-2.11.0/include/openflow/openflow-1.5.h > > > > GPL (v2) > > -------- > > openvswitch-2.11.0/datapath/actions.c > > openvswitch-2.11.0/datapath/compat.h > > openvswitch-2.11.0/datapath/conntrack.c > > openvswitch-2.11.0/datapath/conntrack.h > > openvswitch-2.11.0/datapath/datapath.c > > openvswitch-2.11.0/datapath/datapath.h > > openvswitch-2.11.0/datapath/dp_notify.c > > openvswitch-2.11.0/datapath/flow.c > > openvswitch-2.11.0/datapath/flow.h > > openvswitch-2.11.0/datapath/flow_netlink.c > > openvswitch-2.11.0/datapath/flow_netlink.h > > openvswitch-2.11.0/datapath/flow_table.c > > openvswitch-2.11.0/datapath/flow_table.h > > openvswitch-2.11.0/datapath/linux/compat/geneve.c > > openvswitch-2.11.0/datapath/linux/compat/gre.c > > openvswitch-2.11.0/datapath/linux/compat/gso.c > > openvswitch-2.11.0/datapath/linux/compat/include/net/mpls.h > > openvswitch-2.11.0/datapath/linux/compat/ip_tunnel.c > > openvswitch-2.11.0/datapath/linux/compat/ip_tunnels_core.c > > openvswitch-2.11.0/datapath/linux/compat/lisp.c > > openvswitch-2.11.0/datapath/linux/compat/vxlan.c > > openvswitch-2.11.0/datapath/meter.c > > openvswitch-2.11.0/datapath/meter.h > > openvswitch-2.11.0/datapath/nsh.c > > openvswitch-2.11.0/datapath/vport-gre.c > > openvswitch-2.11.0/datapath/vport-internal_dev.c > > openvswitch-2.11.0/datapath/vport-internal_dev.h > > openvswitch-2.11.0/datapath/vport-netdev.c > > openvswitch-2.11.0/datapath/vport-netdev.h > > openvswitch-2.11.0/datapath/vport-vxlan.c > > openvswitch-2.11.0/datapath/vport.c > > openvswitch-2.11.0/datapath/vport.h > > openvswitch-2.11.0/xenserver/usr_lib_xsconsole_plugins-base_XSFeatureVSwitch. > > py > > > > Update license breakdown comment as well. > > OVN is part of OpenvSwitch and the source code is here - https://github.com/openvswitch/ovs/tree/master/ovn Compiling OpenvSwitch also compiles OVN. OVN doesn't make use of the above files listed by you. You think I still need to update the license ? Also the openvswitch spec file is here - https://src.fedoraproject.org/rpms/openvswitch/blob/master/f/openvswitch.spec and I took that as reference. > > - Own these directories: > > > > [!]: Package requires other packages for directories it uses. > > Note: No known owner of /usr/share/openvswitch, > > /usr/lib/ocf/resource.d/ovn, /usr/share/openvswitch/scripts > > > > - Issue with Provides/Obsoletes > > > > ovn.x86_64: W: self-obsoletion openvswitch-ovn-common < 2.11.0-3 obsoletes > > openvswitch-ovn-common = 2.11.0-2.fc31 > > > > The version you provide should be > to the version you obsolete, so at least > > 2.11.0-4 > > Ack. > > > > > - Use Fedora crypto default: > > > > ovn.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/ovn-nbctl > > SSL_CTX_set_cipher_list > > ovn.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/ovn-sbctl > > SSL_CTX_set_cipher_list > > ovn.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/ovn-trace > > SSL_CTX_set_cipher_list > > > > See https://docs.fedoraproject.org/en-US/packaging-guidelines/CryptoPolicies/ > > > > That is: patch lib/stream-ssl.c:1017 to use "PROFILE=SYSTEM" > > This requires changes int the openvswitch code and I will submit a patch to > the ovs-dev ML > to use "PROFILE=SYSTEM". I will update if that's acceptable or not. > > > > > > - > > > > # Using {_lib} macro will solve the > > # rpmlink error, but will install the files in /usr/lib64/. > > # OVN pacemaker ocf script file is copied in /usr/lib/ocf/resource.d/ovn/ > > # and we are not sure if pacemaker looks into this path to find the > > # OVN resource agent script. > > > > Can't you check if lib64 actually work or not? > > I actually looked into it. I don't we can address this. > I checked with the pacemaker folks and they are not sure if the > ResourceAgent looks into this path for Resource agent scripts. > It would be too risky to assume that /usr/lib64 will work. So I would prefer > that the OVN pacemaker script is installed at /usr/lib. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
