https://bugzilla.redhat.com/show_bug.cgi?id=1689634 --- Comment #4 from Jan Staněk <jstanek@xxxxxxxxxx> --- (In reply to Timothée Floure from comment #3) > I suspect you checked the upstream's master branch [0] instead of the v1.2 > tag [1]? Otherwise I don't undestand the above points since version 1.2 does > not depend on gdk and only requires meson >= 0.43.0. You are correct; sorry about that :) Just add the appropriate/relevant constraints then, please. > I will try to fix this upstream. Good. In case they will be unresponsive, just add it downstream and replace it with the upstream version once they add one. > I also have an issue with new default compiler flag generating build errors > [2]... I'll have to read some documentation! The upstream sets default build options (in meson.build) to `warning_level=2` and `werror=true`, so any warning generated is treated as error and aborts build. The `%set_build_flags` sets (among others) the `-Wall` flag, which I'm guessing is the equivalent of meson's `warning_level=3`. My bet is that our (Fedora) build flags sets off more compiler warnings, which the meson is configured (by upstream) to treats as errors. The proper way to fix that is to write/backport patches to the *source code* that fix those warnings. Since that can take a while, patching the meson.build to not contain `werror=true` is also an acceptable solution (although be sure to add explanation in comment if you do that). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
