https://bugzilla.redhat.com/show_bug.cgi?id=1689634 --- Comment #3 from Timothée Floure <timothee.floure@xxxxxxx> --- > - BuildRequires should follow meson constraints (since meson refuses to > run if they are violated): > - meson >= 0.47.0 > - pkgconfig(wayland-protocols) >= 1.14 > - The package is built without icon support (according to the meson.build). > If this is not intentional, these BR are missing: > - pkgconfig(gdk-3.0) > - pkgconfig(gdk-pixbuf-2.0) I suspect you checked the upstream's master branch [0] instead of the v1.2 tag [1]? Otherwise I don't undestand the above points since version 1.2 does not depend on gdk and only requires meson >= 0.43.0. > - Package does not contain systemd unit file for DBus activation. > Upstream do not ship it, so I'm willing to let this one through for the > initial review; > however, it should be added and ideally submitted to upstream as well. > Example (adapted from dunst): > https://gist.github.com/d8e347c73e3355f3bfd9fcb83afc26ea I will try to fix this upstream. I also have an issue with new default compiler flag generating build errors [2]... I'll have to read some documentation! [0] https://github.com/emersion/mako/blob/87170d5a3499225906a594f47557ea30e34662dd/meson.build [1] https://github.com/emersion/mako/blob/v1.2/meson.build [2] https://paste.sr.ht/~fnux/7735a71ec2526840b98a9785ca53e9b95b86f93b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
