https://bugzilla.redhat.com/show_bug.cgi?id=1689552 --- Comment #4 from Björn Persson <bjorn@xxxxxxxxxxxxxxxxxxxx> --- (In reply to Pavel Zhukov from comment #3) > BuildRequires: gnatcoll-core-devel = 2018 <== Can be changed %{version} for > better maintainability same for %autosetup -n gnatcoll-bindings-gpl-2018-src OK – and maybe I should also add a comment on why I require an exact version. > COPYING and README are duplicated 4 and 3 times in subpackages. Isn't it > better to ship them in main package or different subpackage (like -common > -license whatever) which all subpackages must depend on? The readme files aren't duplicated. They are different, and are all in the -devel subpackage as only developers might have a use for them. That leaves the license. I'm rather sceptical to making a separate subpackage just for the license file. Do you really think that's worthwhile? Note that there is no duplication once the packages are installed. There is just one file, /usr/share/licenses/gnatcoll-bindings/COPYING3, with shared ownership. > P.S. Huge sed expression makes me scared :) but it's kind of ok for > autogenerated files. The Sed syntax is admittedly hard to read. Very unlike Ada. :-) I have added an explanation. I also noticed that the directory /usr/share/doc/gnatcoll was unowned if gnatcoll-bindings-devel was installed but gnatcoll-doc was not. That is now fixed. https://www.rombobjörn.se/packages/gnatcoll-bindings-2018-2/gnatcoll-bindings.spec https://www.rombobjörn.se/packages/gnatcoll-bindings-2018-2/gnatcoll-bindings-2018-2.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
