https://bugzilla.redhat.com/show_bug.cgi?id=1689552 --- Comment #3 from Pavel Zhukov <pzhukov@xxxxxxxxxx> --- Few remarks: BuildRequires: gnatcoll-core-devel = 2018 <== Can be changed %{version} for better maintainability same for %autosetup -n gnatcoll-bindings-gpl-2018-src COPYING and README are duplicated 4 and 3 times in subpackages. Isn't it better to ship them in main package or different subpackage (like -common -license whatever) which all subpackages must depend on? P.S. Huge sed expression makes me scared :) but it's kind of ok for autogenerated files. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
