https://bugzilla.redhat.com/show_bug.cgi?id=1690046 --- Comment #5 from Dave Love <dave.love@xxxxxxxxxxxxxxxx> --- For future reference, the spec URL should be to the raw version for use with fedora-review though that's currently rather broken. (You should probably increment the release tag with changes, at least if it's in copr.) The rpmlint messages aren't important -- it frequently gives false positives -- but you need to obey the packaging guide, specifically about the doc files, as below. Conditionals for SUSE aren't allowed (unfortunately IMHO), though that redefinition looks wrong anyhow. I guess it's harmless, but why the python2 option? Don't buildrequire make, which is in the build root. The version constraints on the BRs aren't necessary since they're always satisfied, and listing them seems confusing. Why isn't there a doc package, as in Debian? The doc source has items which aren't redundant with the man pages -- including about testing -- and I think examples should be doc, though I don't think there are rules about that. LICENSE shouldn't be duplicated in %doc. Documentation should be in %_pkgdocdir, not %_datadir/doc, and relative paths (README.EL7) shouldn't be mixed with absolute ones. The condition for README.EL7 is wrong (spurious "_"). I don't know if it has any effect, but don't use %doc for man pages. It looks as if the test package should require docker (or maybe podman). I don't have VMs with enough space to run the tests; I assume they run OK in EPEL and recent Fedora. I assume you're trying to get sponsored, but I can't see a self-introduction on the -devel list. I'm afraid I can't do it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
