[Bug 1690046] Review Request: Charliecloud - unprivileged container runtime

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1690046



--- Comment #4 from jogas@xxxxxxxx ---

Below are the updated spec and srpm files. The resulting package successfully
builds on epel-7-ppc, epel-7, fedora-28, fedora-29, fedora-30, fedora-rawhide,
opensuse-leap15, and rhelbeta-8. It also defines a python version (3 by default
unless built with `--with python2`), and renames the doc subpackage to test.

Spec
https://copr-dist-git.fedorainfracloud.org/cgit/jogas/charliecloud/charliecloud.git/tree/charliecloud.spec?id=fa6f5bfe817503f56af3bc205b5664560d5f5cc0
SRPM:
https://copr-be.cloud.fedoraproject.org/results/jogas/charliecloud/srpm-builds/00871778/charliecloud-0.9.8-1.el7.src.rpm

The rpmlint remains largely unchanged (see notes).

$ rpmlint charliecloud
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint charliecloud-test
charliecloud-test.x86_64: E: no-ldconfig-symlink
/usr/libexec/charliecloud/test/sotest/lib/libsotest.so.1.0
charliecloud-test.x86_64: W: devel-file-in-non-devel-package
/usr/libexec/charliecloud/examples/mpi/mpihello/hello.c
charliecloud-test.x86_64: E: library-without-ldconfig-postin
/usr/libexec/charliecloud/test/sotest/lib/libsotest.so.1.0
charliecloud-test.x86_64: E: library-without-ldconfig-postun
/usr/libexec/charliecloud/test/sotest/lib/libsotest.so.1.0
charliecloud-test.x86_64: W: devel-file-in-non-devel-package
/usr/libexec/charliecloud/test/chtest/chroot-escape.c
charliecloud-test.x86_64: W: dangling-relative-symlink
/usr/libexec/charliecloud/test/bin ../../../bin
charliecloud-test.x86_64: W: devel-file-in-non-devel-package
/usr/libexec/charliecloud/test/sotest/sotest.c
charliecloud-test.x86_64: W: devel-file-in-non-devel-package
/usr/libexec/charliecloud/test/chtest/setgroups.c
charliecloud-test.x86_64: W: devel-file-in-non-devel-package
/usr/libexec/charliecloud/examples/syscalls/userns.c
charliecloud-test.x86_64: W: devel-file-in-non-devel-package
/usr/libexec/charliecloud/test/chtest/mknods.c
charliecloud-test.x86_64: W: devel-file-in-non-devel-package
/usr/libexec/charliecloud/examples/syscalls/pivot_root.c
charliecloud-test.x86_64: W: devel-file-in-non-devel-package
/usr/libexec/charliecloud/test/chtest/setuid.c
1 packages and 0 specfiles checked; 3 errors, 10 warnings.

rpmlint still complains that the test package has development files. These C
files, in addition to their compiled products, are an integral part of the test
suite. They are not for downstream developers as would be appropriate in a
-devel package. They also illustrate to users of the test suite how things are
working.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux