https://bugzilla.redhat.com/show_bug.cgi?id=1545479 --- Comment #16 from Felix Schwarz <fschwarz@xxxxxxxxxxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #14) > - %{_includedir}/* in %files > > Includes should go to a devel package > > %{_libdir}/cmake/hcc/ too. Not sure if I understood you correctly but hcc is basically a compiler. As far as I know there are no outside users of these header files so probably it does not make sense to split these in a -devel package. (In reply to Robert-André Mauchin from comment #15) > This takes forever to compile. It builds its bundled copy of llvm :-) Takes about 45 minutes on my machine (from the top of my head, might not be accurate). However you need to kill the "licensecheck" process when using fedora-review. That script will take many hours (only using a single core). Btw Tom: I noticed that AMD just deprecated HCC with the ROCm 2.2 release: > Deprecation Notice > > AMD is deprecating HCC to put more focus on HIP development and on other languages supporting > heterogeneous compute. We will no longer develop any new feature in HCC and we will stop > maintaining HCC after its final release, which is planned for June 2019. If your application > was developed with the hc C++ API, we would encourage you to transition it to other languages > supported by AMD, such as HIP or OpenCL. HIP and hc language share the same compiler technology, > so many hc kernel language features (including inline assembly) are also available through > the HIP compilation path. https://github.com/RadeonOpenCompute/hcc/ I assume it still makes sense because hcc is needed right now for the rest of the ROCm stack? (Also the compiler code needs to go somewhere so either they move it into hip or keep hcc around but only as an internal component?) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
