https://bugzilla.redhat.com/show_bug.cgi?id=1689542 --- Comment #11 from Vít Ondruch <vondruch@xxxxxxxxxx> --- Good work! Thx. Just three remarks: * The first %setup call is useless IMO. * I prefer to use -b1 to expand the test suite and later copy/link the test suite on the proper place just in %check section. This is just me being cautious from the experience because it makes harder to accidentally include the test suite in the regenerated gem. > - Regenerated the parser from the grammar * I prefer to explicitly delete the original generated grammar file, just to be really sure. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
