[Bug 1687178] Review Request: python-apprise - Push Notifications that work with just about every platform!

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1687178



--- Comment #25 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
(In reply to Chris Caron from comment #24)
> >  - You could use sed instead of a patch to remove the shebang, it's a bbit overkill for one line.
> 
> This will go away in the next version as it's fixed upstream anyway.
> 
> > - %{__install} → install
> 
> I didn't realise we weren't supposed to use %{__rm}, %{__install}, %{__cp};
> i always thought this was a safer approach.  Noted though, I'll fix this in
> the spec file too.
> 
> > You still need to find a sponsor:
> > https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group
> 
> > (Yes I need to find time to finish the review I gave you)
> 
> I honestly thought the email you sent me entitled 'Fedora packaging
> sponsorship' and the full review of another package you had me do for you
> was hinting the possibility that 'you' might be that person.

yes it is a possibility, you might still do other informal reviews and post
them here to get sponsored, in order to show that you grok the guidelines.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux