https://bugzilla.redhat.com/show_bug.cgi?id=1689542 --- Comment #4 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to Fabio Valentini from comment #3) > Thanks for looking at this! > > > 1) The test suite should be executed. > > That's rather cumbersome, since neither tests nor test data are shipped with > the .gem file. That is nothing exceptional. Guidelines mention this situation. > I would have to generate those separately from the GitHub repository. > Is that really necessary? a) There is no compiler, which would catch basic issues. b) There is no other way to tell if the package works or not. I would like to peek into Koschei and see if it still works. That is not possible without tests. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
