[Bug 1689542] Review Request: rubygem-tomlrb - TOML parser based on racc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1689542



--- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
Thanks for looking at this!

> 1) The test suite should be executed.

That's rather cumbersome, since neither tests nor test data are shipped with
the .gem file.
I would have to generate those separately from the GitHub repository.
Is that really necessary?

> 2) It would be nice if the parsers can be regenerated from source code.

That I can do. The next version I submit here will contain this change.

> And the parser grammar is not needed to ship.

I will %exclude that file from the %files list.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux