[Bug 1687178] Review Request: python-apprise - Push Notifications that work with just about every platform!

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1687178



--- Comment #16 from Chris Caron <lead2gold@xxxxxxxxx> ---
Thanks for the very detailed report.
- Spelling mistakes and shebang issued fixed. The shebang issue was done
through a patch (just because i don't want to spin a whole new release). It is
however already fixed upstream here:
https://github.com/caronc/apprise/commit/764aa5393ffe9e09b7da6bde82078b88e39e5e58
- I'll attach the patch file for transparency anyway :)

With respect to this comment:
- Package must not depend on deprecated() packages.
  Note: python2 is deprecated, you must not depend on it.
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/deprecating-packages/

epel7 is the only one that fits this bill unfortunately; I've had to add the
line at the head of the spec that reads:
%if 0%{?rhel} && 0%{?rhel} <= 7
%global with_python3 0
%endif

If I remove it, i get the failure identified here:
https://koji.fedoraproject.org/koji/taskinfo?taskID=33463886

DEBUG util.py:556:  Last metadata expiration check: 0:00:09 ago on Wed Mar 13
23:50:11 2019.
DEBUG util.py:554:  BUILDSTDERR: No matching package to install:
'python36-requests-oauthlib'
DEBUG util.py:554:  BUILDSTDERR: No matching package to install:
'python36-oauthlib'
DEBUG util.py:554:  BUILDSTDERR: No matching package to install:
'python36-markdown'
DEBUG util.py:554:  BUILDSTDERR: No matching package to install:
'python36-pytest-runner'
DEBUG util.py:554:  BUILDSTDERR: Not all dependencies satisfied
DEBUG util.py:554:  BUILDSTDERR: Error: Some packages could not be found.

But... if we put that line back we go back to all green lights; perhaps these
are missing packages upstream? Maybe i should report them in another ticket?

Anyway... green lighting output (with applied changes):
======================================================
SPEC:
https://copr-be.cloud.fedoraproject.org/results/lead2gold/apprise/fedora-rawhide-x86_64/00868010-python-apprise/python-apprise.spec

Koji:
epel7: https://koji.fedoraproject.org/koji/taskinfo?taskID=33463590
f28: https://koji.fedoraproject.org/koji/taskinfo?taskID=33463592
f29: https://koji.fedoraproject.org/koji/taskinfo?taskID=33463593
f30: https://koji.fedoraproject.org/koji/taskinfo?taskID=33463596
rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=33463598

COPR:
https://copr.fedorainfracloud.org/coprs/lead2gold/apprise/build/868010/


rpmlint (as of now) *.rpm produces
==================================
python3-apprise.noarch: W: python-bytecode-without-source
/usr/lib/python3.7/site-packages/apprise/__pycache__/cli.cpython-37.opt-1.pyc
python3-apprise.noarch: W: python-bytecode-without-source
/usr/lib/python3.7/site-packages/apprise/__pycache__/cli.cpython-37.pyc
python3-apprise-cli.noarch: W: no-documentation
python3-apprise-cli.noarch: W: no-manual-page-for-binary apprise
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

----
I can look into creating a man page; for now would it be satisfactory to just
identify this as a task on my git page (in the ticket system) and get to it for
the next release?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux