https://bugzilla.redhat.com/show_bug.cgi?id=1687178 --- Comment #13 from Chris Caron <lead2gold@xxxxxxxxx> --- Guys, I also dropped all 'python-coverage', and 'python-tox' reference since I'm no longer using that in the %test section (so spec got much cleaner). This allowed me to enable testing for f28 and epel (previously disabled because of reference to tox). But then 'epel7' couldn't pass 3 tests because they reference features only available in newer builds of 'py.test' and 'requests'. SO then i created a patch file for epel7 to work around this which means i had to drop the %autosetup in the %prep section (so i could JUST apply the patch to epel7 builds). It's been changed to just %setup so i could wrap the %patchX entry. Anyway, there is no doubt i broke some standards here introducing the patch file. I'm not sure how to properly host the .patch file (as it is now it's just dropped in my SOURCES directory prior to my build; it's referenced relatively in .spec). Is this satisfactory? I'll attach the spec to this ticket. Everything still builds nicely with this additional clean-up. SPEC: https://copr-be.cloud.fedoraproject.org/results/lead2gold/apprise/fedora-30-i386/00867578-python-apprise/python-apprise.spec COPR: https://copr.fedorainfracloud.org/coprs/build/867578/ Koji: epel7: https://koji.fedoraproject.org/koji/taskinfo?taskID=33443066 f28: https://koji.fedoraproject.org/koji/taskinfo?taskID=33443069 f29: https://koji.fedoraproject.org/koji/taskinfo?taskID=33443070 f30: https://koji.fedoraproject.org/koji/taskinfo?taskID=33443071 rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=33443073 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
