[Bug 1687178] Review Request: python-apprise - Push Notifications that work with just about every platform!

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1687178



--- Comment #5 from Chris Caron <lead2gold@xxxxxxxxx> ---
Thank you guys for all your feedback.  It was also suggested on the mailing
lists to not use flake8 as it's to harsh to fail a %test because of a pep8
issue.  I couldn't agree with this more, so i dropped this to just be py.test
references instead.  I'll satisfy my own PEP8 OCD with travisCI and not with
RPMS.

I should add that i'm also the developer of this product.  So yes i realize i
pushed a new version out but supplied you with the last one.  It was kind of
happening at the same time.

I addressed all of the comments you identified above (including the new version
reference):

Updated Spec:
https://copr-be.cloud.fedoraproject.org/results/lead2gold/apprise/fedora-rawhide-x86_64/00866973-python-apprise/python-apprise.spec

Here is the Koji output:
epel7: https://koji.fedoraproject.org/koji/taskinfo?taskID=33411608
f28: https://koji.fedoraproject.org/koji/taskinfo?taskID=33411610
f29: https://koji.fedoraproject.org/koji/taskinfo?taskID=33411612
f30: https://koji.fedoraproject.org/koji/taskinfo?taskID=33411614
rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=33411616

Copr:
https://copr.fedorainfracloud.org/coprs/lead2gold/apprise/build/866973/


On a side note; the license was recently changed (About a month or so ago) from
GPLv3 to MIT.  I didn't realize i didn't update this on the header of my SPEC
file.  I'll update this on the next build.

Thank you guys again for all of your feedback!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux