[Bug 1687178] Review Request: python-apprise - Push Notifications that work with just about every platform!

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1687178

Artur Iwicki <fedora@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora@xxxxxxxxxx



--- Comment #2 from Artur Iwicki <fedora@xxxxxxxxxx> ---
>Group:          Development/Languages
>BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
>...
>Group: Development/Utils
>...
>%clean
Not used in Fedora. Drop 'em.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

>URL:            http://github.com/caronc/apprise
I'd change this to https.

>Source0:        https://github.com/caronc/apprise/archive/v%{version}/apprise-%{version}.tar.gz
You can reuse the %{URL} here to make the line shorter.

>LANG=en_US.utf8 PYTHONPATH=%{buildroot}%{python2_sitelib} coverage2 run ./setup.py test
I believe this may require you to add the en_US langpack via BuildRequires.
See:
https://fedoraproject.org/wiki/Changes/Remove_glibc-langpacks-all_from_buildroot

>%defattr(-,root,root,-)
Not needed. These are the default values.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_permissions

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux