[Bug 1680043] Review Request: toolbox - Unprivileged development environment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1680043



--- Comment #8 from Debarshi Ray <debarshir@xxxxxxxxxx> ---
Updated Spec URL: https://rishi.fedorapeople.org/toolbox.spec
Updated SRPM URL: https://rishi.fedorapeople.org/toolbox-0.0.6-1.fc29.src.rpm

(In reply to Carl George from comment #7)
> I see what you mean about the release tarball versus the git tag tarball. 
> Sorry about that, I'm just used to having to use the tag.  Thanks for
> setting me straight.

No need to apologize. It got me to sit down and reason about some of the things
we take for granted. :)

> Only thing left is these new rpmlint warnings.
> 
>     toolbox.spec:39: W: macro-in-comment %check
>     toolbox.spec:40: W: macro-in-comment %meson_test

Oops! Silly me, I only ran rpmlint on the installed RPM this time.

> I would change your commented check section to something like this to
> resolve it.
> 
>     %check
>     # https://github.com/debarshiray/toolbox/issues/68
>     #%%meson_test

Yes, fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux