https://bugzilla.redhat.com/show_bug.cgi?id=1680043 Carl George <carl@george.computer> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #7 from Carl George <carl@george.computer> --- Those are fair points about meson. I don't have a problem with using it in the specfile, I was more just curious. I see what you mean about the release tarball versus the git tag tarball. Sorry about that, I'm just used to having to use the tag. Thanks for setting me straight. Only thing left is these new rpmlint warnings. toolbox.spec:39: W: macro-in-comment %check toolbox.spec:40: W: macro-in-comment %meson_test I would change your commented check section to something like this to resolve it. %check # https://github.com/debarshiray/toolbox/issues/68 #%%meson_test Pending that minor cleanup, PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
